From bec3734676faf3868ea225e0316e77ad5a7e4421 Mon Sep 17 00:00:00 2001 From: Gab Virebent Date: Sat, 11 Jul 2026 13:37:23 +0200 Subject: Switch Nym WS transport to nym-client's binary protocol, drop second base64 layer Client.Send now speaks nym-client's native binary websocket protocol (tag || recipient || conn_id || data_len || data) instead of wrapping the ciphertext in a JSON text message, which required base64-encoding it a second time on top of the browser's own base64 layer. The reader's self-address query also switched to the binary protocol: nym-client picks text-vs-binary for every later "received" push based on the format of the last request seen on a connection, so leaving the reader in JSON/text mode would have made nym-client run a lossy UTF-8 conversion over the now-unencoded binary payload, corrupting it. Fixed the binary Received-frame parsing along the way (previous code assumed a fixed 16-byte tag with no length prefix, which never matched the real protocol and was never exercised while the connection stayed text-mode). Verified end-to-end against the real embedded nym-client 1.1.76 binary, with the exact wire format cross-checked against upstream nym source at the pinned build commit. --- cmd/nymdrop-reader/memguard_verify_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'cmd/nymdrop-reader/memguard_verify_test.go') diff --git a/cmd/nymdrop-reader/memguard_verify_test.go b/cmd/nymdrop-reader/memguard_verify_test.go index 3ab5fce..7b240e6 100644 --- a/cmd/nymdrop-reader/memguard_verify_test.go +++ b/cmd/nymdrop-reader/memguard_verify_test.go @@ -6,7 +6,6 @@ import ( "crypto/ecdh" "crypto/rand" "crypto/sha256" - "encoding/base64" "encoding/hex" "io" "testing" @@ -53,9 +52,9 @@ func TestDecryptMessageAfterMemguard(t *testing.T) { packet := append(append(append([]byte{}, ephPriv.PublicKey().Bytes()...), iv...), ciphertext...) noncePrefix := hex.EncodeToString(make([]byte, 16)) + ":" - dataB64 := base64.StdEncoding.EncodeToString(append([]byte(noncePrefix), packet...)) + raw := append([]byte(noncePrefix), packet...) - got, err := decryptMessage(dataB64, readerPriv) + got, err := decryptMessage(raw, readerPriv) if err != nil { t.Fatalf("decryptMessage: %v", err) } -- cgit v1.2.3